fix: parser will throw an error when address is null/no param but param is present #1011
Conversation
ibishal
requested review from
magicmatatjahu,
jonaslagoni,
smoya and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
ibishal
changed the title
parameter is null or param.length === 0
ibishal
changed the title
|
@ibishal the Spectral rule should apply for AsyncAPI spec v3. Not necessary for v2 (unless no cost of adding) |
|
FYI @ibishal, this PR is part of #1019 and by that, part of this Bounty Program issue. If you want to participate in the Bounty Program and get a reward ($), please express your interest in #1016 and include an outline of the work you will do for each of the rules that should be added. |
i had created this PR solving the issue #875 (it is overlapping with issue #1019 ), should i close this ?
i have sent a basic outline in slack(dms), should i put it in the issue too(more briefly outlining each rules) |
One is a bug, the other is the issue that mentions to work on such a bugfix as part of the bounty program.
You should follow standard procedures. Express your desire of working on such an issue, say how would you do with each of the tasks that are part of the bounty issue and not only with one. I will choose the right person based on that info. |
|
Are you gonna include the rule for v3? |
Of course, you can work in any of the issues you want, that doesn't mean it is assigned to you. We only assign issues in programs such as Bounty, GSoC, etc. Meaning other people is also free to work in the same one and send a PR in parallel. |
|
@smoya this PR is ready for review |
Description
Now when there is
parameterbut the address not contain any, then it will throw an errorRelated issue(s)
Fixes #875